Origins now advertise themselves as writebackhosts #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bandaid fix for now to allow origins to show themselves as writeback hosts to allow for puts. This helps seperate them from relying on topology to get this information. This is just a band-aid for now, as we should make the writebackhost configurable and able to be set or not set when an origin is spun up.
Made writebackhost be advertised within `AdvertiseOSDF`
joereuss12
force-pushed
the
writebackhost-set-in-origin-branch
branch
from
8b3bc64 to
b066f2c
Compare
bbockelm
requested changes
Dec 27, 2023
There was a problem hiding this comment.
I'd like to completely rework the approach here.
- No client header changes should be necessary. The target of the redirect of the PUT command should be all that's needed. We had to do this as a separate header originally because we weren't using the HTTP redirect functionality.
- That is, a standard
curlshould be able to do the upload.
- That is, a standard
- There should be a change in the advertisement from origin to the director. However, instead of advertising the
WriteBackHost, we should simply advertise whether writes are enabled (a boolean flag) as the endpoint for PUTs should be the same as the endpoint for any other operation. - For the fix around the periodic advertisement, that looks like it's potentially an important bugfix. Please separate that out and have @turetske review it as a standalone PR.
|
Closed by #622 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bandaid fix for now to allow origins to show themselves as writeback hosts to allow for puts. This helps seperate them from relying on topology to get this information. This is just a band-aid for now, as we should make the writebackhost configurable and able to be set or not set when an origin is spun up.