Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry UI APIs #515

Merged
merged 17 commits into from
Jan 2, 2024
Merged

Registry UI APIs #515

merged 17 commits into from
Jan 2, 2024

Conversation

haoming29
Copy link
Contributor

@haoming29 haoming29 commented Dec 19, 2023

Closes #264

  • Please refer to Swagger UI / Swagger documentation for available APIs
  • This PR didn't include support for custom registration field to scale down the scope (it's already ~2000 lines of change!), which will be a separate PR
  • Other follow-up tickets will be added to improve test coverage and improve the robustness
  • Note: This PR breaks the Web UI for registry as the data type of admin_metadata has been changed from string to json. I would assume this will be part of the UI update from @CannonLock
  • Note: This PR has foreseeable merge conflict with Require Admin approval for new caches #439 / Namespace registry admin #462 . Depending on which PR gets merged first, the other PR requires non-trivial conflict resolution. @turetske We can talk about how to fix the conflict.

@haoming29 haoming29 changed the title Add APIs to Registry UI Registry UI APIs Dec 20, 2023
@haoming29 haoming29 added the enhancement New feature or request label Dec 20, 2023
@haoming29 haoming29 added this to the v7.4.0 milestone Dec 20, 2023
@haoming29 haoming29 marked this pull request as ready for review December 20, 2023 00:10
@haoming29 haoming29 requested a review from bbockelm December 20, 2023 00:10
Copy link
Collaborator

@bbockelm bbockelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A modest number of TODO items for the review -- the most important to focus on is the institutional validation.

web_ui/frontend/app/api/docs/pelican-swagger.yaml Outdated Show resolved Hide resolved
web_ui/frontend/app/api/docs/pelican-swagger.yaml Outdated Show resolved Hide resolved
web_ui/frontend/app/api/docs/pelican-swagger.yaml Outdated Show resolved Hide resolved
web_ui/frontend/app/api/docs/pelican-swagger.yaml Outdated Show resolved Hide resolved
web_ui/frontend/app/api/docs/pelican-swagger.yaml Outdated Show resolved Hide resolved
registry/registry_db.go Show resolved Hide resolved
registry/registry_db.go Outdated Show resolved Hide resolved
registry/registry_db_test.go Outdated Show resolved Hide resolved
registry/registry_ui.go Outdated Show resolved Hide resolved
registry/registry_ui_test.go Show resolved Hide resolved
@haoming29 haoming29 requested a review from bbockelm December 29, 2023 21:44
@CannonLock CannonLock mentioned this pull request Jan 2, 2024
Copy link
Collaborator

@bbockelm bbockelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I'm sure there are additional items I've missed but I like the conceptual design, we already went through the first round of issues, and I worry about merge conflicts across such a large change.

@bbockelm bbockelm merged commit 6102f06 into PelicanPlatform:main Jan 2, 2024
9 checks passed
@haoming29 haoming29 deleted the registry-ui-p2 branch January 2, 2024 19:14
@haoming29 haoming29 restored the registry-ui-p2 branch January 2, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Namespace web UI
3 participants