Add status filter to registry API, improve Swagger docs #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoming29
added
enhancement
haoming29
changed the title
jhiemstrawisc
requested changes
Jan 8, 2024
| } | ||
| if existingStatus == Approved { | ||
| log.Errorf("User '%s' is trying to modify approved namespace registration with id=%d", user, id) | ||
| ctx.JSON(http.StatusForbidden, gin.H{"error": "You don't have permission to modify an approved registration. Please contact your federation administrator"}) |
There was a problem hiding this comment.
How do we handle key rotations if we don't allow namespace owners to modify their registrations?
There was a problem hiding this comment.
I think for now we'd better off now allowing them to modify, even the keys, as we aren't dealing with key rotation in the system. #383 . I imagine to do the rotation, we will have a separate endpoint for partial update like PATCH /registry_ui/namespace/:id/pubkey so that users know what they are doing. For the full-update like what you pointed out here, we should be strict.
* Improve Swagger to include csrf token, query params, RBAC * Refactor namespace db function to allow generic filtering * Control ns visibility based on auth status
haoming29
force-pushed
the
registry-api-p3
branch
from
032db0d to
157c43b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #606 and #591