-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Registry UI #625
Add Registry UI #625
Conversation
CannonLock
commented
Jan 9, 2024
- Add Components for viewing Namespace
- Add forms for creating and updating Namespaces
- Update login page for CIlogin Users
- Add Components for viewing Namespace - Add forms for creating and updating Namespaces - Update login page for CIlogin Users
- Fix Types
@haoming29 This test failure isn't likely to be my error |
Nope. That's a flaky test, will re-run it |
- Update the pubkey to Material UI built-in
…into registry-crud
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't seem to allow no-authed users to view registry page? When I didn't login and go to https://<registry-host>/
or https://<registry-host>/view/registry/
, I will be redirected to the login page.
- Display error if provided in json
- Fixup, add minHeight to multiline so styles so the original presentation aligns with the other fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Left suggestions as comment.
- Fixup based on review - Don't expand text on approve/deny - Add the pubkey placeholder - Add security helper text - Remove redirect on registry
LGTM after the revision! One last thing to add and we should be good to go. @CannonLock
|
- Add some clarifying text - Add avatar if you own the namespace
@haoming29 I made some tweaks in my changes to reduce the amount of text. It is hard to get people to read text so I tried to add some ui elements to answer your questions and your text suggestions where UI couldn't answer them all. Sorry about missing the issue you had to fix, I thought I saw a second suggested change for the input form but I looked through a couple times and couldn't find it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the revision. Thanks for putting this together.
- Account for undefined authentication
97bd6bb
to
934025d
Compare
Looks like the only test failure is the client side test that's supposed to be fixed by @joereuss12 soon, if this is what we talked about during the standup? Will merge ours first. |