Fixes to origin/director advertise to client #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbockelm
force-pushed
the
fixes-to-622-advertise-origin
branch
from
a4bf760 to
2e63437
Compare
bbockelm
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Did some further refactoring to reduce a double-query to the director.
Added a commit to allow "fallback reads" so I could test via federation-in-a-box as follows:
PELICAN_ORIGIN_ENABLEFALLBACKREAD=true \
PELICAN_ORIGIN_ENABLEVOMS=false \
PELICAN_ORIGIN_EXPORTVOLUME=/tmp/test \
pelican serve --module origin --module registry --module director -d
and then doing a pelican object copy to/from the instance. Also checks out with stashcp moving files to/from the OSDF.
Now that we can do an upload and download via federation-in-a-box, we should think about adding that to either the unit test or the integration tests.
There may be further unit test cleanup judging from failures on main; I'll leave that to @joereuss12
These fixes are for PR PelicanPlatform#622 which helps reinstate backwards compatibility. Changes include: - Returning `uploadFile` to its original state - Running a PUT on the director to get PUT endpoint instead of a GET - Moved this logic to `client/main.go` when we gather ns info - Moved the gathering of ns info to a seperate function
Not sure why these are not getting caught
- Cleanup common paths between GET and PUT. - Ensure the director query is only done once. - Have director always internally route the PUT to an origin query
Now internal defaults match the documentation defaults.
If `Origin.EnableFallbackRead` is set, then the origin will be selected by the director to serve clients if there are no available caches. Fixes PelicanPlatform#608
joereuss12
force-pushed
the
fixes-to-622-advertise-origin
branch
from
2e63437 to
c719bab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fixes are for PR #622 which helps reinstate backwards compatibility. Changes include:
UploadFileto its original stateclient/main.gowhen we gather ns info