Fix Config Links #634
Merged
Fix Config Links #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CannonLock
commented
Jan 10, 2024
CannonLock
commented
- Use path base aware link component for page navigation
- Use path base aware link component for page navigation
CannonLock
force-pushed
the
base-path-aware-link
branch
from
9e8d746 to
6c232ab
Compare
|
@haoming29 The issue was this page also used the Material-UI Link component which is not aware of the basepath that I set. |
haoming29
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
The links to various server page in config page works, but I found that the link pelican icon has always leads to the "serve page option" with exception for registry page, the icon of which leads to /view/registry/index.html. I think we need a way to return to the "current server page" as well as going back to "serve matrix" page
I guess this could be a separate issue if @bbockelm is fine with that.
|
@haoming29 Thats another issue, and isn't pressing because IIRC the pelican in a box is currently internal. The other urls will get redirected to that servers home. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.