Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear/correct logging at program exit #657

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Clear/correct logging at program exit #657

merged 1 commit into from
Jan 17, 2024

Conversation

haoming29
Copy link
Contributor

@haoming29 haoming29 commented Jan 12, 2024 •
edited
Loading

Fixes #598
Partially make #644 a bit easier to debug but not a direct fix.

Give a clearer log message at the program exit, by outputting daemon names to log message
Also fix the error "Federation is Cancelled" at the exit but in fact a no-error message.

@haoming29 haoming29 requested a review from joereuss12 January 12, 2024 19:59
@haoming29 haoming29 added the enhancement New feature or request label Jan 12, 2024
@haoming29 haoming29 added this to the v7.5.0 milestone Jan 12, 2024
joereuss12
joereuss12 reviewed Jan 12, 2024
View reviewed changes
Copy link
Contributor

@joereuss12 joereuss12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When running this to test it out, the only "DaemonName" I can get to print out is xrootd and no other daemons. Is this to be expected? Otherwise this LGTM

@haoming29
Copy link
Contributor Author

When running this to test it out, the only "DaemonName" I can get to print out is xrootd and no other daemons. Is this to be expected? Otherwise this LGTM

Sorry for the delayed response! It depends. If you ran without alias, i.e. as pelican then this is the expected behavior. When you ran with osdf alias, you may see two daemons, "xrootd" and "cmsd"

@haoming29 haoming29 closed this Jan 17, 2024
@haoming29 haoming29 reopened this Jan 17, 2024
@joereuss12
Copy link
Contributor

Okay gotcha, LGTM then once these tests go thru

joereuss12
joereuss12 approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@joereuss12 joereuss12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haoming29 haoming29 merged commit 2e369ac into PelicanPlatform:main Jan 17, 2024
17 checks passed
@haoming29 haoming29 deleted the better-exit-log branch January 17, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joereuss12 joereuss12 joereuss12 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v7.5.0
Development

Successfully merging this pull request may close these issues.

Server exits with errors
2 participants
@haoming29 @joereuss12