Filter config #669
Merged
Filter config #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CannonLock It seems like a bunch of GHA failed in the PR. Could you take a look and fix them? |
CannonLock
force-pushed
the
filter-config
branch
from
06640d3 to
e7144df
Compare
CannonLock
force-pushed
the
filter-config
branch
2 times, most recently
from
285f9bd to
5a306df
Compare
- Rename `nsregistry` to `registry` - Have the parameters.json create in the web_ui folder via go generator - Filter out the disabled config parameters in the config view
CannonLock
force-pushed
the
filter-config
branch
from
41fddd7 to
70ffdd3
Compare
|
@haoming29 Alright this is ready for review, copying the parameters.json was more of a adventure then it needed to be. |
haoming29
suggested changes
Jan 30, 2024
There was a problem hiding this comment.
LGTM. One thing I noticed is that after I ran make web-build, there's a new file generated at frontend/public/data/parameters.json which is not added to .gitignore. Is this file supposed to be committed? If so, could you add it to your PR? Or it's a file for local only?
Co-authored-by: Haoming Meng <41393704+haoming29@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #654