Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CVMFS shortcut within Pelican client #78

Merged

Conversation

joereuss12
Copy link
Contributor

Removing all instances of this shortcut since CVMFS is moving to be https instead. Gutted out handle_cvmfs.go as well as any other instances. Did some light tests by hand and /osgconnect transfers seem to still work without it.

Fixes #62

Removing all instances of this shortcut since CVMFS is moving to be https instead. Gutted out handle_cvmfs.go as well as any other instances. Did some light tests by hand and /osgconnect transfers seem to still work without it.
@joereuss12 joereuss12 requested a review from bbockelm August 31, 2023 20:55
Copy link
Collaborator

@bbockelm bbockelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We may need to accept "cvmfs" as a valid flag in the CLI for backward compatibility-- but I'm somewhat dubious anyone ever set that. So, let's keep as is and only do the backward compat if we see it's needed.

@bbockelm bbockelm merged commit a25e8e0 into PelicanPlatform:main Aug 31, 2023
jhiemstrawisc added a commit to jhiemstrawisc/pelican that referenced this pull request Sep 19, 2023
This PR brings to Pelican a floating PR from the old OSDF client. Its intention is to improve
reporting of error messages.
jhiemstrawisc added a commit that referenced this pull request Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove CVMFS shortcut in code
2 participants