Fix director responses #92

bbockelm · 2023-09-02T13:45:28Z

This fixes up the header generation for the director response. Now, when I try the command from @jhiemstrawisc in #68, I get the following in the response headers:

...
< location: https://dtn-pas.cinc.nrp.internet2.edu:8443/ospool/PROTECTED/justin.hiemstra
< x-pelican-authorization: issuer=https://osg-htc.org/ospool
< x-pelican-namespace: namespace=/ospool/PROTECTED, require-token=true
< x-pelican-token-generation: issuer=https://osg-htc.org/ospool, max-scope-depth=4, strategy=OAuth2

Fixes #68

The client is looking for an attribute named `require-token`; the server was replying with `use-token-on-read`. Now both are using `require-token`.

When generating the origin record, we need the full namespace object filled out (including the authorization and token-generation info). This is because the origin's policy is used when later responding to clients. The same thing is not needed for the cache ads; the cache namespace info is only used for determining whether or not a cache supports a particular namespace.

jhiemstrawisc

Ah, good catch with the originNS --> nsAd bug.

bbockelm added 2 commits September 2, 2023 08:57

Fix structured data in header

fef21d5

The client is looking for an attribute named `require-token`; the server was replying with `use-token-on-read`. Now both are using `require-token`.

bbockelm force-pushed the fix_director_response branch from ff460a9 to 52efca8 Compare September 2, 2023 13:57

jhiemstrawisc approved these changes Sep 5, 2023

View reviewed changes

jhiemstrawisc merged commit 3a25fb4 into PelicanPlatform:main Sep 5, 2023
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix director responses #92

Fix director responses #92

bbockelm commented Sep 2, 2023

jhiemstrawisc left a comment

Fix director responses #92

Fix director responses #92

Conversation

bbockelm commented Sep 2, 2023

jhiemstrawisc left a comment

Choose a reason for hiding this comment