Add pre-commit hooks for the repo #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces pre-commit configurations to run golangci before any commits occur. Goal is to decrease the number of "fixup linter" type commit messages in the repo.
Yaml files with multiple `---` separators are considered "multiple-document yaml files." Without the addition of the `--allow-multiple-documents` flag to the check-yaml hook, parsing these will fail.
|
@bbockelm I didn't see anyone assigned for review on this, but it would be a nice feature to have at this point. I tested and made a small change so that our |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces pre-commit configurations to run golangci before any commits occur. Goal is to decrease the number of "fixup linter" type commit messages in the repo.
Fixes #83