Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simple verification to namespace registration #94

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Add simple verification to namespace registration #94

merged 1 commit into from
Sep 6, 2023

Conversation

bbockelm
Copy link
Collaborator

@bbockelm bbockelm commented Sep 2, 2023

This forbids a few potentially-confusing prefixes, including:

  • Any path component starting with '.'
  • The root prefix '/'
  • /pelican, /api, /view

Fixes #53

@bbockelm
Add simple verification to namespace registration
ee528a7 
This forbids a few potentially-confusing prefixes, including:
- Anything starting with '.'
- The root prefix '/'
- /pelican, /api, /view
@bbockelm bbockelm added this to the v7.0.0 milestone Sep 2, 2023
jhiemstrawisc
jhiemstrawisc approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@jhiemstrawisc jhiemstrawisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think the choice to move the check for existing namespaces and the prefix validation into the verified block is probably a good choice.

@jhiemstrawisc jhiemstrawisc merged commit 55d03a4 into PelicanPlatform:main Sep 6, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhiemstrawisc jhiemstrawisc jhiemstrawisc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.0.0
Development

Successfully merging this pull request may close these issues.

Restrict some paths from being registered as namespace prefixes
2 participants
@bbockelm @jhiemstrawisc