Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import parameters.json into website #972

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

CannonLock
Copy link
Contributor

@CannonLock CannonLock commented Mar 21, 2024

Unify Build Process

Adds check that go generate has been run on the latest commit
Moves make web-build into goreleaser before which will make how we build dev binaries more similar to how we build production binaries
Rewrites the dockerfile moving the web build into the gorelease section
Doesn't needlessly update parameters.json on go generate ./..

Closes #971

@CannonLock CannonLock force-pushed the issue-971 branch 9 times, most recently from cf9067c to 5033ce5 Compare March 22, 2024 20:42
@CannonLock CannonLock requested a review from haoming29 March 22, 2024 20:43
Copy link
Contributor

@haoming29 haoming29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions/concerns left in comments

.pre-commit-config.yaml Outdated Show resolved Hide resolved
.goreleaser.yml Show resolved Hide resolved
web_ui/frontend/public/data/parameters.json Outdated Show resolved Hide resolved
Adds check that go generate has been run on the latest commit
Moves make web-build into goreleaser before which will make how we build dev binaries more similar to how we build production binaries
Rewrites the dockerfile moving the web build into the gorelease section
Doesn't needlessly update parameters.json on go generate ./..
Copy link
Contributor

@haoming29 haoming29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@haoming29 haoming29 merged commit 696e8d7 into PelicanPlatform:main Mar 27, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing parameters.json file in containers
2 participants