Allow configurable cache watermarks #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoming29
added
enhancement
bbockelm
previously requested changes
Mar 23, 2024
There was a problem hiding this comment.
I like the implementation but have questions about the interface.
- Does it match what we did for local_cache?
- Is it better/more friendly to have percentages (90%) instead of floats (0.90). Providing percentages may be more user friendly as the number provided is unambiguous.
May be a good idea to have a quick chat with someone from the facilitation team to get their feedback on the subject.
Agree. Percentage (integer) should be more user friendly and have better consistency with |
turetske
requested changes
Apr 1, 2024
|
@bbockelm GitHub requires your approval before merging. Feel free to taking another look. |
bbockelm
dismissed
their stale review
Review by Emma after my initial set of changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #665