Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not log "director test timeout" warning if director can't be reached out #991

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Do not log "director test timeout" warning if director can't be reached out #991

merged 3 commits into from
Apr 4, 2024

Conversation

haoming29
Copy link
Contributor

Closes #981

@haoming29 haoming29 added this to the v7.7.0 milestone Mar 26, 2024
@haoming29
Copy link
Contributor Author

haoming29 commented Mar 26, 2024 •
edited
Loading

With #545 merged in, this PR need to add the same feature to cache tests, so it's not yet ready for review.

nvm, #545 successfully refactored out the function and the changes are synced after rebase

@haoming29 haoming29 added bug Something isn't working cache Issue relating to the cache component origin Issue relating to the origin component labels Mar 27, 2024
@haoming29 haoming29 requested review from jhiemstrawisc and turetske and removed request for jhiemstrawisc April 1, 2024 14:56
@haoming29
Copy link
Contributor Author

Offload Justin's queue to review my PR to Emma. Thank you both!

turetske
turetske approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@turetske turetske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@turetske turetske merged commit e1772bd into PelicanPlatform:main Apr 4, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turetske turetske turetske approved these changes

Assignees
No one assigned
Labels
bug Something isn't working cache Issue relating to the cache component origin Issue relating to the origin component
Projects
None yet
Milestone
v7.7.0
Development

Successfully merging this pull request may close these issues.

Cancel director test report timeout at the origin/cache if they can not be advertised to the director
2 participants
@haoming29 @turetske