Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More verbose error message at director registration failure #992

Merged
merged 4 commits into from
Apr 1, 2024

Conversation

haoming29
Copy link
Contributor

@haoming29 haoming29 commented Mar 26, 2024

Closes #976

Update: while debugging, I figured that there is still space for improvement for the error message, will mark it ready for review once that's addressed.

@haoming29 haoming29 added this to the v7.7.0 milestone Mar 26, 2024
@haoming29 haoming29 added enhancement New feature or request director Issue relating to the director component labels Mar 26, 2024
@haoming29 haoming29 requested a review from turetske March 29, 2024 20:18
Copy link
Collaborator

@turetske turetske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@turetske turetske merged commit 5635a1e into PelicanPlatform:main Apr 1, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
director Issue relating to the director component enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More verbose response error messages when director registration failed
2 participants