-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved plugin error messaging #999
Improved plugin error messaging #999
Conversation
Maybe hold off on a review until we get a format that everyone can agree on. Any changes requested should be an easy fix but I want to get a confirmed wanted hold message before I develop further. |
After talks with some facilitators, they told us ways to improve error messaging from the plugin. Now, all errors from the plugin now begin with PELICAN CLIENT ERROR as well as end with HOSTNAME and GLIDEIN_SITE
Released I used similar code for all the outputs, made a function that formats the error message for us
78d1f1a
to
47ae9e9
Compare
@jhiemstrawisc This is ready for review now! Here is the updated message:
With this being the Pelican piece:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A great addition that should be of benefit to users and facilitators alike!
After talks with some facilitators, they told us ways to improve error messaging from the plugin. Now, all errors from the plugin now begin with PELICAN CLIENT ERROR as well as end with HOSTNAME and GLIDEIN_SITE
Before:
After: