Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved plugin error messaging #999

Merged

Conversation

joereuss12
Copy link
Contributor

After talks with some facilitators, they told us ways to improve error messaging from the plugin. Now, all errors from the plugin now begin with PELICAN CLIENT ERROR as well as end with HOSTNAME and GLIDEIN_SITE

Before:

Transfer input files failure at the execution point using protocol osdf. Details: Error from 
slot1_7@glidein_253984_295706592@uct2-c516.mwt2.org: FILETRANSFER:1:non-zero exit (1) from 
/var/lib/condor/execute/dir_253982/glide_YoREfU/stash_plugin. |Error:  Failure downloading 
osdf:///chtc/staging/jrreuss/foo-v1.txt: failed connection setup: server returned 403 Forbidden 
( URL file = osdf:///chtc/staging/jrreuss/foo-v1.txt )|

After:

Transfer input files failure at the execution point using protocol osdf. Details: Error from 
slot1_6@glidein_3084899_80207786@build4002.chtc.wisc.edu: FILETRANSFER:1:non-zero exit (1) from stash_plugin. 
|Error:  PELICAN CLIENT ERROR downloading osdf:///chtc/staging/jrreuss/foo-v1.txt: failed connection setup: 
server returned 403 Forbidden HOSTNAME: build4002 GLIDEIN_SITE: Wisconsin ( URL file = osdf:///chtc/staging/jrreuss/foo-v1.txt )|

@joereuss12 joereuss12 added this to the v7.7.0 milestone Mar 27, 2024
@joereuss12 joereuss12 linked an issue Mar 27, 2024 that may be closed by this pull request
1 task
@joereuss12
Copy link
Contributor Author

Maybe hold off on a review until we get a format that everyone can agree on. Any changes requested should be an easy fix but I want to get a confirmed wanted hold message before I develop further.

@joereuss12 joereuss12 marked this pull request as draft March 28, 2024 16:51
After talks with some facilitators, they told us ways to improve error
messaging from the plugin. Now, all errors from the plugin now begin with
PELICAN CLIENT ERROR as well as end with HOSTNAME and GLIDEIN_SITE
Released I used similar code for all the outputs, made a function that
formats the error message for us
@joereuss12 joereuss12 force-pushed the improve-plugin-errors-branch branch from 78d1f1a to 47ae9e9 Compare April 2, 2024 14:24
@joereuss12 joereuss12 marked this pull request as ready for review April 2, 2024 14:27
@joereuss12
Copy link
Contributor Author

@jhiemstrawisc This is ready for review now! Here is the updated message:

012 (11127448.000.000) 2024-04-02 09:19:07 Job was held.
        Transfer input files failure at the execution point using protocol osdf. Details: Error from 
slot1_8@glidein_1704396_51805840@node0252.palmetto.clemson.edu: FILETRANSFER:1:non-zero exit (11) from 
stash_plugin. |Error: Pelican Client Error: downloading osdf:///chtc/staging/jrreuss/foo-v1.txt: failed 
connection setup: Get "https://osg-gftp2.pace.gatech.edu:8443/chtc/staging/jrreuss/foo-v1.txt": net/http:
timeout awaiting response headers (Pelican Version: 7.6.2; Site: Clemson-Palmetto) 
( URL file = osdf:///chtc/staging/jrreuss/foo-v1.txt )|
        Code 13 Subcode 256

With this being the Pelican piece:
Pelican Client Error: downloading osdf:///chtc/staging/jrreuss/foo-v1.txt: failed connection setup: Get "https://osg-gftp2.pace.gatech.edu:8443/chtc/staging/jrreuss/foo-v1.txt": net/http: timeout awaiting response headers (Pelican Version: 7.6.2; Site: Clemson-Palmetto)

  • Note that the site does not show up if not run on the ospool (if there is no machineAd attribute GLIDEIN_Site)

Copy link
Member

@jhiemstrawisc jhiemstrawisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A great addition that should be of benefit to users and facilitators alike!

@jhiemstrawisc jhiemstrawisc merged commit d50a841 into PelicanPlatform:main Apr 4, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements to Pelican Plugin Error Messages
2 participants