trailing / messes up signing of request #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rw2, can you take another look at this? I think this fixes part of the issue with path-style lists, but it breaks regular GETs where we still need the object name in the generated URL (see failing tests). On a side note, I think we still want to keep the |
|
Good news, now it's more than a one line fix! Turned out there were two things. First the path'ing wasn't being done correctly. Second, once that was fixed, the correct paths were not being used in the correct places. So now that's fixed and the unit tests pass again. |
|
Closing this PR, as it looks like it's a subset of the work in #58 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.