Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests covering the list and stat functionality #64

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

bbockelm
Copy link
Collaborator

In particular, this includes a (commented out for now) reproducer for the issue described in #63. That test can be re-enabled when the bug is fixed (or used to test the fix itself!).

@bbockelm bbockelm requested a review from rw2 December 11, 2024 23:50
In particular, this includes a (commented out for now) reproducer
for the issue described in PelicanPlatform#63.  That test can be re-enabled when
the bug is fixed (or used to test the fix itself!).
Copy link
Collaborator

@rw2 rw2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the diff looks fine, nothing scary there. but tests are failing due to a build error.

@bbockelm
Copy link
Collaborator Author

There was an upstream outage at the CERN repo when the PR was created. It caused an older version of XRootD to get pulled and triggering the build error.

Looks better now.

@bbockelm bbockelm requested a review from rw2 December 13, 2024 13:49
Copy link
Collaborator

@rw2 rw2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks.

@bbockelm bbockelm merged commit d82504a into PelicanPlatform:main Dec 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants