Fix compile error for Mbed TF-M V8M target #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix compile error for Mbed TF-M V8M target, usually without FLASHIAP 1. Use DEVICE_FLASH to exclude FLASHIAP code 2. Fix MBED_MAJOR_VERSION doesn't get in to exclude mbedtls_psa_crypto_free().
|
Have a look? |
|
Thank you, I'll take a look. |
| @@ -14,6 +14,7 @@ | |||
| // limitations under the License. | |||
| // ---------------------------------------------------------------------------- | |||
| #ifdef MBED_CONF_MBED_CLOUD_CLIENT_PSA_SUPPORT | |||
| #include "platform/mbed_version.h" | |||
There was a problem hiding this comment.
@ccli8
I don't see any of the #define in this file being used: https://github.com/ARMmbed/mbed-os/blob/master/platform/include/platform/mbed_version.h
What compile errors are you seeing without this include file?
There was a problem hiding this comment.
@marcuschangarm I met link error with undefined mbedtls_psa_crypto_free symbol:
Compile [100.0%]: psa_driver_crypto.c
[Warning] psa_driver_crypto.c@547,5: implicit declaration of function 'mbedtls_psa_crypto_free' is invalid in C99 [-Wimplicit-function-declaration]
Link: mbed-cloud-client-example
[Warning] @0,0: L3912W: Option 'legacyalign' is deprecated.
[Error] @0,0: L6218E: Undefined symbol mbedtls_psa_crypto_free (referred from BUILD/NU_M2354/ARM/mbed-cloud-client/factory-configurator-client/psa-driver/source/psa_driver_crypto.o).
Checking the lines below, MBED_MAJOR_VERSION is not available, which is defined in mbed_version.h:
teetak01
added
the
Approved
|
Thanks @ccli8 @marcuschangarm I'll mark this for next public release as the changes have already been integrated internally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[x] I confirm this contribution is my own and I agree to license it with Apache 2.0.
[x] I confirm the moderators may change the PR before merging it in.
[x] I understand the release model prohibits detailed Git history and my contribution will be recorded to the list at the bottom of CONTRIBUTING.md.
Summary of changes
This PR tries to fix compile error for Mbed TF-M V8M target, usually without
FLASHIAP:DEVICE_FLASHto excludeFLASHIAPcodeMBED_MAJOR_VERSIONisn't available, which is needed to excludembedtls_psa_crypto_free().