Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace smriprep calls with dependency calls #217

Merged
merged 6 commits into from
Feb 23, 2023

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Feb 22, 2023

Closes None, but works toward #199.

Changes proposed in this pull request

  • The classes and functions used directly in aslprep from smriprep are:
    • init_anat_preproc_wf
    • ReconAll
    • _bids_relative
    • collect_derivatives
  • I tried copying the code from smriprep 0.6.1 into the aslprep folder to see what the diff was. There weren't any meaningful differences, except maybe the removal of surfaces from io_spec.json in the aslprep version.

@tsalo tsalo added refactor Changes to the codebase that don't impact workflow inputs or outputs. maintenance Issues/PRs related to maintenance. Dependency versions, dependencies, etc. labels Feb 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2023

Codecov Report

Base: 39.95% // Head: 39.64% // Decreases project coverage by -0.32% ⚠️

Coverage data is based on head (f890ebd) compared to base (92f2ede).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
- Coverage   39.95%   39.64%   -0.32%     
==========================================
  Files         192      176      -16     
  Lines       19940    18868    -1072     
==========================================
- Hits         7967     7480     -487     
+ Misses      11973    11388     -585     
Impacted Files Coverage Δ
aslprep/interfaces/reports.py 91.30% <100.00%> (ø)
aslprep/niworkflows/viz/utils.py 55.78% <100.00%> (ø)
aslprep/workflows/asl/outputs.py 44.10% <100.00%> (ø)
aslprep/workflows/base.py 88.46% <100.00%> (ø)
aslprep/niworkflows/anat/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
aslprep/niworkflows/interfaces/ants.py 0.00% <0.00%> (-57.82%) ⬇️
aslprep/niworkflows/interfaces/nitransforms.py 0.00% <0.00%> (-50.00%) ⬇️
aslprep/niworkflows/anat/skullstrip.py 0.00% <0.00%> (-30.00%) ⬇️
aslprep/niworkflows/anat/ants.py 0.00% <0.00%> (-12.36%) ⬇️
aslprep/niworkflows/interfaces/masks.py 46.74% <0.00%> (-11.84%) ⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tsalo tsalo requested a review from mattcieslak February 23, 2023 14:56
Copy link
Contributor

@mattcieslak mattcieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to be rid of aslprep.smriprep!

@tsalo tsalo merged commit 3ccc8ac into PennLINC:main Feb 23, 2023
@tsalo tsalo deleted the remove-smriprep branch February 23, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issues/PRs related to maintenance. Dependency versions, dependencies, etc. refactor Changes to the codebase that don't impact workflow inputs or outputs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants