Write out GIFTI and CIFTI CBF maps #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #361 +/- ##
==========================================
+ Coverage 75.99% 78.81% +2.81%
==========================================
Files 39 39
Lines 4120 4149 +29
Branches 595 600 +5
==========================================
+ Hits 3131 3270 +139
+ Misses 791 685 -106
+ Partials 198 194 -4 ☔ View full report in Codecov by Sentry. |
tsalo
changed the title
tsalo
commented
Dec 8, 2023
| ("asl_file", "inputnode.bold_file"), | ||
| ("asl_anat", "inputnode.bold_file"), |
There was a problem hiding this comment.
I was feeding in the minimally-preprocessed aslref-space ASL file here, so the goodvoxels mask was in a different space and resolution than the anatomical-space data meant to be put in the CIFTI.
There was a problem hiding this comment.
This is what was causing #360 I believe.
tsalo
commented
Dec 8, 2023
| @@ -565,6 +565,7 @@ def init_asl_wf( | |||
| mem_gb=mem_gb, | |||
| name="asl_anat_wf", | |||
| ) | |||
| asl_anat_wf.inputs.inputnode.resolution = "native" | |||
There was a problem hiding this comment.
I was missing this, even though it is in fMRIPrep.
tsalo
commented
Dec 8, 2023
| workflow.connect([ | ||
| (inputnode, ds_asl_cifti, [ | ||
| ("asl_cifti", "in_file"), | ||
| ("source_files", "source_file"), |
There was a problem hiding this comment.
The datasinks needed the source_file input.
This was referenced Dec 8, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #356.
Changes proposed in this pull request