Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix volume selection and temporarily remove --dummy-scans parameter #468

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Nov 26, 2024

Closes none, but addresses a bug identified by user cindylucerog in https://neurostars.org/t/extract-deltam-failed-to-run/31056.

Changes proposed in this pull request

  • Use reduced version of metadata in ExtractCBF calls. This is the version of metadata produced by asl_native_wf, wherein volume-wise fields only retain values from relevant volumes.
  • Disable the --dummy-scans parameter temporarily, because it wasn't working as intended. THIS IS A BREAKING CHANGE.

@tsalo tsalo added bug Something isn't working breaking-change PRs that change results or interfaces. labels Nov 26, 2024
@tsalo tsalo merged commit dbc5716 into PennLINC:main Nov 26, 2024
26 checks passed
@tsalo tsalo deleted the fix-volume-selection branch November 26, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change PRs that change results or interfaces. bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant