Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] update toy BIDS App version used for CircleCI testing #90

Merged
merged 6 commits into from
May 4, 2023

Conversation

zhao-cy
Copy link
Collaborator

@zhao-cy zhao-cy commented May 4, 2023

Changes in this PR

  • The Docker image for CircleCI testing is upgraded to version datalad0.17.2_v5, with toybidsapp version 0.0.7 sif file included.
  • The example toybidsapp YAML files (unzipped and zipped dataset) are updated too:
    • changed the version to 0.0.7 too;
    • added --dummy argument;
  • Also fixed the readthedocs error due to the new release of urlib3. See below for more.

Therefore, if you use the latest example YAML files for toy BIDS App, make sure you are also using the latest version of toy BIDS App (0.0.7)!

@zhao-cy zhao-cy added enhancement New feature or request examples-enhancement Enhancements in examples labels May 4, 2023
@zhao-cy zhao-cy added the documentation Improvements or additions to documentation label May 4, 2023
@zhao-cy
Copy link
Collaborator Author

zhao-cy commented May 4, 2023

Fixed the readthedocs build error: Followed how XCP fixed this error.

Details see: PennLINC/xcp_d/pull/877

@zhao-cy zhao-cy merged commit 480da1d into main May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request examples-enhancement Enhancements in examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant