Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to ignore phase data #849

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Add ability to ignore phase data #849

merged 1 commit into from
Nov 8, 2024

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Nov 7, 2024

The ability to ignore phase data was added in #679, but it looks like it was accidentally removed in #745. This PR adds it back in.

Changes proposed in this pull request

  • Add "phase" option to --ignore parameter.

@tsalo tsalo added the bug Something isn't working label Nov 7, 2024
@tsalo tsalo requested a review from mattcieslak November 7, 2024 18:18
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.76%. Comparing base (cff8bdc) to head (58a1e4e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #849   +/-   ##
=======================================
  Coverage   28.76%   28.76%           
=======================================
  Files          68       68           
  Lines       10025    10025           
  Branches     1109     1109           
=======================================
  Hits         2884     2884           
  Misses       7042     7042           
  Partials       99       99           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mattcieslak mattcieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, do we really not need to change anything anywhere else?

@tsalo
Copy link
Member Author

tsalo commented Nov 8, 2024

#679 added all of the important parts- we just accidentally dropped the "phase" option for the "--ignore" parameter in #745, so that's the only change we should need.

@mattcieslak mattcieslak merged commit ee895af into master Nov 8, 2024
20 checks passed
@tsalo tsalo deleted the ignore-phase branch November 8, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants