Move from pennydreadfulmagic.com cookies to .pennydreadfulmagic.com cookies #13309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ookies This will let us know you are an admin on logs. I'm not sure what changed here, maybe the config got messed up? But this will put us back in the right spot.
| @@ -92,8 +92,14 @@ | |||
| oauth.logout() | |||
| target = request.args.get('target', 'home') | |||
| if bool(urllib.parse.urlparse(target).netloc): | |||
| return redirect(target) | |||
| return redirect(url_for(target)) | |||
| response = redirect(target) | |||
Check warning
Code scanning / CodeQL
URL redirection from remote source Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 4 months ago
To fix the problem, we need to ensure that the target parameter is validated properly before using it in a redirect. One way to do this is to maintain a list of allowed redirect targets and check that the user-provided target is in this list. If the target is not in the list, we should redirect to a default safe location.
- Create a list of allowed redirect targets.
- Check if the
targetparameter is in the list of allowed targets. - If the
targetis not in the list, redirect to a default safe location.
Suggested changeset
1
shared_web/flask_app.py
| @@ -92,7 +92,8 @@ | ||
| oauth.logout() | ||
| ALLOWED_REDIRECTS = ['home', 'profile', 'dashboard'] # Add all allowed targets here | ||
| target = request.args.get('target', 'home') | ||
| if bool(urllib.parse.urlparse(target).netloc): | ||
| response = redirect(target) | ||
| else: | ||
| if target in ALLOWED_REDIRECTS: | ||
| response = redirect(url_for(target)) | ||
| else: | ||
| response = redirect(url_for('home')) | ||
| # Clean up any session cookie set with no domain created when the site was misconfigured. |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will let us know you are an admin on logs.
I'm not sure what changed here, maybe the config got messed up? But this will
put us back in the right spot.