Skip to content

Conversation

@rniczh
Copy link
Contributor

@rniczh rniczh commented Nov 5, 2025

Context:

Latest LLVM update #2122 requires nanobind>=2.9

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:
[sc-103342]

@rniczh rniczh changed the title Rniczh/update nanobind 2.9 Update nanobind 2.9 Nov 5, 2025
@mehrdad2m mehrdad2m self-requested a review November 5, 2025 15:55
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@paul0403
Copy link
Member

paul0403 commented Nov 5, 2025

Should we wait until the current run on main finishes?

@dime10
Copy link
Contributor

dime10 commented Nov 5, 2025

Should we wait until the current run on main finishes?

Yeah we shouldn't build llvm on PR branches, that will probably max out the cache if there are multiple instances.

@rniczh rniczh merged commit d3f5875 into main Nov 5, 2025
38 checks passed
@rniczh rniczh deleted the rniczh/update-nanobind-2.9 branch November 5, 2025 17:30
@zsb-xqc zsb-xqc added the chore label Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants