Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support iswap, siswap, and their adjoints #114

Merged
merged 2 commits into from
Sep 19, 2022
Merged

support iswap, siswap, and their adjoints #114

merged 2 commits into from
Sep 19, 2022

Conversation

timmysilv
Copy link
Contributor

As the title says. These gates have native counterparts in cirq. I will work on making general adjoint support for plugins once all the native gates needing work are supported right out of the gate (hehehe)

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #114 (81e7560) into master (fe2c417) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #114   +/-   ##
=======================================
  Coverage   99.23%   99.23%           
=======================================
  Files           8        8           
  Lines         393      393           
=======================================
  Hits          390      390           
  Misses          3        3           
Impacted Files Coverage Δ
pennylane_cirq/cirq_device.py 98.92% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

I wonder if we could define the Adjoint(S) and Adjoint(T) as instances of the cirq.ZPowGate? But that's something we can further look into later.

@timmysilv
Copy link
Contributor Author

I too think that's the way! I'm planning on using those PowGate classes to implement a generic solution for adjoints and powers after this PR

@timmysilv timmysilv merged commit 519d027 into master Sep 19, 2022
@timmysilv timmysilv deleted the swap-support branch September 19, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants