-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for ops raised to a power; remove old custom ops #115
Conversation
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
==========================================
- Coverage 99.23% 99.23% -0.01%
==========================================
Files 8 8
Lines 393 392 -1
==========================================
- Hits 390 389 -1
Misses 3 3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Left some comments
CHANGELOG.md
Outdated
* Removed the unnecessary `CPhase` and `ISWAP` operations from the | ||
plugin's custom support because PennyLane supports them. | ||
[(#115)](https://github.com/PennyLaneAI/pennylane-cirq/pull/115) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should stick this under "breaking changes".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice solution! Thanks for this PR :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
Introduce support for operations raised to a power using Cirq PowGates.
List of Cirq PowGates:
As well, pennylane_cirq supports gates that exist in Cirq but not in PennyLane. This included CPhase and ISWAP, but those exist in PennyLane! I've removed the non-PL operation support for those and ensured the PL operation support.