Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prod support to cirq device #183

Merged
merged 8 commits into from
Apr 19, 2024
Merged

Add prod support to cirq device #183

merged 8 commits into from
Apr 19, 2024

Conversation

astralcai
Copy link
Contributor

@astralcai astralcai commented Apr 8, 2024

Add support for Prod observable.

Shortcut Stories:
[sc-60542]

@Alex-Preciado
Copy link
Contributor

Relevant Shortcut Stories: [sc-60542]

@Qottmann
Copy link

can you retrigger and if it still gets stuck get someone with the power to overwrite it? Next one in line for demo blockers 🙃

@Qottmann
Copy link

Qottmann commented Apr 18, 2024

@Alex-Preciado could we overwrite the codecov requirement and merge this? This is currently blocking the work on fixing demos

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.43%. Comparing base (ed12d7f) to head (c5c220c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #183   +/-   ##
=======================================
  Coverage   99.43%   99.43%           
=======================================
  Files           8        8           
  Lines         352      357    +5     
=======================================
+ Hits          350      355    +5     
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alex-Preciado
Copy link
Contributor

Hey @Qottmann, we noticed that the Codecov Token was missing in this repository. I've added it now to this repository's secrets. I'm merging @astralcai 's changes now with a green CI status. You should now be unblocked 😎

@Alex-Preciado Alex-Preciado merged commit c7cfefe into master Apr 19, 2024
9 checks passed
@Alex-Preciado Alex-Preciado deleted the prod branch April 19, 2024 03:03
@Qottmann
Copy link

Thanks so much 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants