Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: support for Identity on multiple wires #186

Merged
merged 2 commits into from
Apr 22, 2024
Merged

BugFix: support for Identity on multiple wires #186

merged 2 commits into from
Apr 22, 2024

Conversation

astralcai
Copy link
Contributor

Context
apply fails with Identity on multiple wires because cirq.I only accepts a single wire.

Change
Replace cirq.I with cirq.IdentityGate which does allow specifying the number of wires

Shortcut
[sc-61681]

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.44%. Comparing base (c7cfefe) to head (a80198d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #186   +/-   ##
=======================================
  Coverage   99.43%   99.44%           
=======================================
  Files           8        8           
  Lines         357      358    +1     
=======================================
+ Hits          355      356    +1     
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astralcai astralcai requested a review from Qottmann April 22, 2024 16:10
Copy link

@Qottmann Qottmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question before approving

pennylane_cirq/cirq_device.py Show resolved Hide resolved
Copy link

@Qottmann Qottmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @astralcai !

@astralcai astralcai merged commit d899426 into master Apr 22, 2024
9 checks passed
@astralcai astralcai deleted the identity branch April 22, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants