Skip to content

Re-structure the Lightning-Base class and core src files #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

maliasadi
Copy link
Member

@maliasadi maliasadi commented Mar 17, 2025

Context:

  • The LightningBaseStateVector, LightningBaseAdjointJacobian, LightningBaseMeasurements and LightningInterpreter base classes now can be found at pennylane_lightning.lightning_base.

  • The new lightning_base module further enables the relocation of core files from pennylane_lightning/core/src/* to pennylane_lightning/core/*.

  • The license classifier and project.license as a TOML table are deprecated in favor of a SPDX license expression and removed in pyproject.toml.

  • To speedup the recompilation of C++ source code, ccache is also added to Makefile.

[sc-87767]

@maliasadi maliasadi added the ci:build_wheels Activate wheel building. label Mar 17, 2025
@maliasadi maliasadi marked this pull request as ready for review March 17, 2025 21:12
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.58%. Comparing base (720b4da) to head (9868b4d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1098      +/-   ##
==========================================
- Coverage   95.70%   95.58%   -0.12%     
==========================================
  Files         237      182      -55     
  Lines       41288    29331   -11957     
==========================================
- Hits        39513    28036   -11477     
+ Misses       1775     1295     -480     
Flag Coverage Δ
unit_tests 95.58% <100.00%> (-0.12%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maliasadi maliasadi removed the ci:build_wheels Activate wheel building. label Mar 25, 2025
@maliasadi maliasadi added the ci:build_wheels Activate wheel building. label Mar 25, 2025
@maliasadi maliasadi modified the milestone: v0.41.0 Apr 1, 2025
@maliasadi maliasadi changed the title Remove dispensable C++ source code in Lightning wheels Re-structure the Lightning-Base class and core src files Apr 1, 2025
@LuisAlfredoNu
Copy link
Contributor

The documentation builder complains about _version.py.
https://app.readthedocs.com/projects/xanaduai-pennylane-lightning/builds/2991445/#34254152--263
😕

@maliasadi maliasadi requested a review from LuisAlfredoNu May 1, 2025 13:28

final_state = state.get_final_state(circuit)
return self.LightningMeasurements(final_state).measure_final_state(circuit)
return super().simulate(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll trigger GPU tests after getting the first round of reviews

@LuisAlfredoNu
Copy link
Contributor

The CIs have a issue with the version file.

@maliasadi
Copy link
Member Author

The CIs have a issue with the version file.

@LuisAlfredoNu Nothing can be done here! The location of _version is changed in this PR ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants