Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bump #55

Merged
merged 4 commits into from
Oct 18, 2019
Merged

Version bump #55

merged 4 commits into from
Oct 18, 2019

Conversation

josh146
Copy link
Member

@josh146 josh146 commented Oct 18, 2019

Description of the Change:

  • Version bump

  • The way measurement statistics works has changed in the latest version of PennyLane. Now, rather than shots=0 referring to 'analytic' mode, there is a separate analytic argument. Further, the num_shots argument has been removed from Device.samples().

@josh146 josh146 requested a review from antalszava October 18, 2019 19:11
Copy link
Contributor

@antalszava antalszava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through the changes, looks good! :) Left a couple of comments related to minor changes.

In pennylane-pq/pennylane_pq/pqops.py, in class QubitUnitary(BasicProjectQGate):
Instead of unitary_gate.matrix = np.matrix(par[1]), it might be better to have unitary_gate.matrix = np.array(par[1])

.github/CHANGELOG.md Outdated Show resolved Hide resolved
pennylane_pq/devices.py Outdated Show resolved Hide resolved
pennylane_pq/devices.py Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
tests/test_compare_with_default_qubit.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 18, 2019

Codecov Report

Merging #55 into master will decrease coverage by 1.73%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
- Coverage     100%   98.26%   -1.74%     
==========================================
  Files           6        6              
  Lines         229      230       +1     
==========================================
- Hits          229      226       -3     
- Misses          0        4       +4
Impacted Files Coverage Δ
pennylane_pq/devices.py 97.48% <100%> (-2.52%) ⬇️
pennylane_pq/_version.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a68739...16e2045. Read the comment docs.

@josh146 josh146 merged commit a0e59df into master Oct 18, 2019
@josh146 josh146 deleted the v0.6_update branch October 18, 2019 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants