Skip to content

Commit

Permalink
Add corrections to pyscf dipole coeffs (#3908)
Browse files Browse the repository at this point in the history
* add small corrections to pyscf dipole results

* update changelog

* Apply suggestions from code review

Co-authored-by: Utkarsh <utkarshazad98@gmail.com>

* trigger ci

---------

Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
Co-authored-by: lillian542 <Lillian.frederiksen@xanadu.ai>
  • Loading branch information
3 people authored and mudit2812 committed Mar 20, 2023
1 parent 1465f13 commit fc66efb
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions doc/releases/changelog-dev.md
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,10 @@
* Fixed parameter broadcasting support with `qml.counts` in most cases, and introduced explicit errors otherwise.
[(#3876)](https://github.com/PennyLaneAI/pennylane/pull/3876)

* A correction is added to the reference values in `test_dipole_of` to account for small changes
(~2e-8) in the computed dipole moment values, resulting from the new [PySCF 2.2.0](https://github.com/pyscf/pyscf/releases/tag/v2.2.0) release.
[(#3908)](https://github.com/PennyLaneAI/pennylane/pull/3908)

<h3>Contributors</h3>

This release contains contributions from (in alphabetical order):
Expand Down
4 changes: 2 additions & 2 deletions tests/qchem/of_tests/test_dipole_of.py
Original file line number Diff line number Diff line change
Expand Up @@ -164,9 +164,9 @@
x_h2o = np.array([0.0, 1.431, -0.887, 0.0, -1.431, -0.887, 0.0, 0.0, 0.222])

coeffs_h2o = []
coeffs_h2o.append([-0.03700799, 0.03700799, 0.03700799, -0.03700799])
coeffs_h2o.append([-0.03700797, 0.03700797, 0.03700797, -0.03700797])
coeffs_h2o.append([0.0])
coeffs_h2o.append([0.28530454, 0.111, 0.111, -0.37101744, -0.37101744])
coeffs_h2o.append([0.28530461, 0.111, 0.111, -0.3710174, -0.3710174])

ops_h2o = []
ops_h2o.append(
Expand Down

0 comments on commit fc66efb

Please sign in to comment.