New OrbitalRotation decomposition
#3171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3171 +/- ##
==========================================
- Coverage 99.69% 99.69% -0.01%
==========================================
Files 274 274
Lines 23884 23883 -1
==========================================
- Hits 23810 23809 -1
Misses 74 74
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
obliviateandsurrender
requested changes
Oct 17, 2022
There was a problem hiding this comment.
Thanks, @isaacdevlugt! Looking good. Just a couple of minor suggestions, and it will be good to go.
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
obliviateandsurrender
approved these changes
Oct 17, 2022
|
Thanks for implementing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: New decomposition for
OrbitalDecomposition.Description of the Change: Decomposes into
SingleExcitationgates instead of more elementary gates (e.g. control gates,Hadamard, etc.)Benefits:
There are two really big advantages to decomposing down into SingleExcitation gates:
default.qubitandlightningnatively supportSingleExcitation, so the execution will be fasterSingleExcitationhas a parameter-shift rule defined, so less circuits will be executed to get the gradientRelated GitHub Issues: #3169