Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vn entropy and mutual info shot vec validation check #3180

Merged
merged 6 commits into from
Oct 18, 2022

Conversation

antalszava
Copy link
Contributor

@antalszava antalszava commented Oct 18, 2022

Adds a validation check for the shot-vector case of vn_entropy and mutual_info (#2819) - makes the required logic to be implemented.

[sc-23175]

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@antalszava antalszava requested a review from rmoyard October 18, 2022 14:50
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #3180 (b55a5f0) into master (315ff3e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3180   +/-   ##
=======================================
  Coverage   99.69%   99.69%           
=======================================
  Files         274      274           
  Lines       23885    23922   +37     
=======================================
+ Hits        23811    23848   +37     
  Misses         74       74           
Impacted Files Coverage Δ
pennylane/_qubit_device.py 99.66% <100.00%> (+<0.01%) ⬆️
pennylane/operation.py 97.04% <100.00%> (+0.04%) ⬆️
pennylane/ops/op_math/composite.py 100.00% <100.00%> (ø)
pennylane/ops/qubit/hamiltonian.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@rmoyard rmoyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @antalszava it looks good to me 👍

@antalszava antalszava merged commit b728eb8 into master Oct 18, 2022
@antalszava antalszava deleted the vn_entropy_mut_info_shot_vec_noimpl branch October 18, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants