Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using _wire setter and use map_wires instead. #3186

Merged
merged 57 commits into from
Oct 28, 2022
Merged

Stop using _wire setter and use map_wires instead. #3186

merged 57 commits into from
Oct 28, 2022

Conversation

AlbertMitjans
Copy link
Contributor

@AlbertMitjans AlbertMitjans commented Oct 19, 2022 •
edited
Loading

  1. Remove all the _wires properties.
  2. Stop using op._wires = new_wires, use qml.map_wires(op, wire_map=dict(zip(op.wires, new_wires))) instead.
  3. Deprecate remap_tape_wires

AlbertMitjans and others added 30 commits October 6, 2022 15:37
@AlbertMitjans
feat (Operator): ✨ Add change_wires method.
f74974f
@AlbertMitjans
refactor (Operator): ♻️ Change name from change_wires to map_wires.
fa485fb
@AlbertMitjans
Remove error
2a96f38
@AlbertMitjans
change name
1b41b7b
@AlbertMitjans
feat (map_wires): ✨ Add top-level qml.map_wires function.
ce28817
@AlbertMitjans
Add tests
9602bb8
@AlbertMitjans
Only check subset of wires present in Operator
3f119d7
@AlbertMitjans
Add tests
b5f97ef
@AlbertMitjans
Add tests
e595203
@AlbertMitjans
Merge branch 'operator-map-wires' into map-wires-function
8696cfd
@AlbertMitjans
chore (changelog): ✏️ Add feature to changelog.
84f9efb
@AlbertMitjans
Merge branch 'operator-map-wires' into map-wires-function
e788e78
@AlbertMitjans
More fixes
df7c1e2
@AlbertMitjans
More fixes
fcb6463
@AlbertMitjans
Merge branch 'operator-map-wires' into map-wires-function
f037fb8
@AlbertMitjans
Merge branch 'master' into map-wires-function
3155c20
@AlbertMitjans
Fix test
60cc399
@AlbertMitjans
Merge branch 'master' into map-wires-function
052ba22
@AlbertMitjans
Fix tests
aee5da4
@AlbertMitjans
Merge branch 'master' into map-wires-function
21ac750
@AlbertMitjans
Revert
761a8c8
@AlbertMitjans
Revert
d98b5b8
@AlbertMitjans @albi3ro
Update doc/releases/changelog-dev.md
d221c55 
Co-authored-by: Christina Lee <christina@xanadu.ai>
@AlbertMitjans
Update changelog
839ed46
@AlbertMitjans
Add docs
8259909
@AlbertMitjans
Remove _wire setter and use map_wires instead.
d945716
@AlbertMitjans
Fix tests. Add map_wires to symbolic_op.
fd3cdc4
@AlbertMitjans
Add test.
90e1470
@AlbertMitjans
Stop using _wires setter.
f2712da
@AlbertMitjans
Merge branch 'map-wires-function' into remove-wire-setter
6141136
@AlbertMitjans AlbertMitjans added this to the v0.27.0 milestone Oct 27, 2022
@AlbertMitjans AlbertMitjans removed the do not merge ⚠️ Do not merge the pull request until this label is removed label Oct 27, 2022
@AlbertMitjans AlbertMitjans added the review-ready 👌 PRs which are ready for review by someone from the core team. label Oct 27, 2022
albi3ro
albi3ro requested changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Changelog
  2. Think there might be some merge artifacts
  3. Little confused by the different locations of wire mapping in the pattern matching PR
  4. Should test that the warning is emitted by remap_tape_wires with pytest.warns

@AlbertMitjans
Copy link
Contributor Author

AlbertMitjans commented Oct 28, 2022 •
edited
Loading

  1. Changelog

Done

  1. Think there might be some merge artifacts

Fixed

  1. Little confused by the different locations of wire mapping in the pattern matching PR

Some of the changes were wrong, so thank you for catching this! Now I fixed the commutation_dag.py file and the changes will make more sense. I also added some comments to clarify the final changes.

  1. Should test that the warning is emitted by remap_tape_wires with pytest.warns

Done

@AlbertMitjans AlbertMitjans requested a review from albi3ro October 28, 2022 10:25
@AlbertMitjans @albi3ro
Update doc/releases/changelog-dev.md
9537af1 
Co-authored-by: Christina Lee <christina@xanadu.ai>
albi3ro
albi3ro approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always love removing TODO's :)

@AlbertMitjans AlbertMitjans merged commit f206330 into master Oct 28, 2022
@AlbertMitjans AlbertMitjans deleted the remove-wire-setter branch October 28, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albi3ro albi3ro albi3ro approved these changes

@Jaybsoni Jaybsoni Awaiting requested review from Jaybsoni

Assignees
No one assigned
Labels
review-ready 👌 PRs which are ready for review by someone from the core team.
Projects
None yet
Milestone
v0.27.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AlbertMitjans @albi3ro