-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QInfo broadcasting (1/3)] Support for qml.math
density matrix functions
#4173
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #4173 +/- ##
=======================================
Coverage 99.77% 99.77%
=======================================
Files 340 340
Lines 30566 30595 +29
=======================================
+ Hits 30496 30525 +29
Misses 70 70
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! just a couple of comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think the ongoing discussions should be finished before merging to clear up the roadmap for the broadcasting and potential DensityMatrixMP
changes, but otherwise this PR looks merge-ready to me beyond non-blocking suggestions.
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Co-authored-by: Christina Lee <christina@xanadu.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Currently the quantum information functions in
qml.math
and the QNode transforms inqml.qinfo
do not support broadcasting. Support for this will be added in a sequence of 3 PRs, of which this is the first. The individual aims of the PRs are roughly:qml.math.reduced_dm
into two functions,qml.math.reduced_dm_from_sv
andqml.math.reduced_dm_from_dm
, each of which supports broadcasting. Also begin a deprecation cycle forqml.math.reduced_dm
.qml.math
. Also change their signatures to accept only a density matrix, and begin a deprecation cycle for passing in state vectors.qml.qinfo
QNode transforms.