-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support snapshots in DefaultQubit2
#4193
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #4193 +/- ##
=======================================
Coverage 99.77% 99.77%
=======================================
Files 342 342
Lines 30709 30737 +28
=======================================
+ Hits 30639 30667 +28
Misses 70 70
|
Co-authored-by: Christina Lee <christina@xanadu.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was testing it out with code from #4196 , and the preprocessing was decomposing the snapshots away. We need to edit preprocess.py
line 56 to manually specify that the new device support snapshots.
@albi3ro Can you check if the last change was what you meant? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 I'm happy with this :)
Co-authored-by: Christina Lee <christina@xanadu.ai>
[sc-33774] |
Basically port over the implementation from
DefaultQubit
and add a couple of tests.