More fermionic dunders #4209
Merged
More fermionic dunders #4209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soranjh
reviewed
Jun 12, 2023
soranjh
reviewed
Jun 14, 2023
There was a problem hiding this comment.
Looks great, thanks @lillian542. My main comment is about using arrays with length != 1. I think that should not be allowed.
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
…lane into more_fermionic_dunders
Jaybsoni
reviewed
Jun 15, 2023
Co-authored-by: Jay Soni <jbsoni@uwaterloo.ca>
soranjh
approved these changes
Jun 15, 2023
lillian542
commented
Jun 15, 2023
Jaybsoni
approved these changes
Jun 15, 2023
frederikwilde
pushed a commit
that referenced
this pull request
Jul 5, 2023
* create fermiword class * create fermisentence class * [skip ci] modify order * [skip ci] remove unused import * [skip ci] add deepcopy method * [skip ci] replace list with generator * [skip ci] add tests * [skip ci] add tests * [skip ci] add tests * add tests * [skip ci] run black * [skip ci] copy fermiword * [skip ci] rebase and fix conflict * [skip ci] run black * [skip ci] copy fermiword * [skip ci] add tests * add test to tests_passing_pylint * add sum mult test * [skip ci] add tests * [skip ci] add pow tests * add tests * fix pylint * add error tests * fix pylint * add TODO * modify docstrings * update changelog * update changelog * modify docstrings * fix codecov * add code review comments * add test for indices * fix codefactor * multiply FermiWord and FermiSentence * add tests for fw * fs * add and test multiplying fermiword with integer or float * allow number times fermi sentence * update tests * Allow subtracting one FermiSentence from another * Allow substraction * clean up formatting and tests * Add multiplication by complex * Add more tests and reorganize * update change log * add test * black formatting * Add constants to FermiWord and FermiSentence * add tests * radd and rsub methods plus tests * missing lines for codecov * start adding support for tensors * numpy and pennylane numpy tensors plus tests for __add__ and __sub__ * add tests for multiplying by tensor * fix formatting issues post merge * add comment regarding overriding numpy dunders * Apply suggestions from code review Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com> * check len of array before adding to FeriSentence * Raise error if array with len>2 is passed to arithmetic dunders * Apply suggestions from code review Co-authored-by: Jay Soni <jbsoni@uwaterloo.ca> * Update doc/releases/changelog-dev.md * round to 10 digits --------- Co-authored-by: soranjh <soranjh@yahoo.com> Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com> Co-authored-by: Jay Soni <jbsoni@uwaterloo.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change:
__rmul__toFermiWordandFermiSentenceto handle things like2 * FermiWord(int,floatorcomplexor numpyarraymultiplied byFermiWordorFermiSentence)__mul__method to allow multiplication betweenFermiWord,FermiSentence,float,int,complexor numpyarray__add__and__radd__method to to bothFermiWordandFermiSentenceto allow addition betweenFermiWord,FermiSentenceand constants__sub__and__rsub__method to bothFermiWordandFermiSentenceto allow subtraction betweenFermiWord,FermiSentenceand constants