-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register QuantumScript
and QuantumTape
as pytrees
#4608
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albi3ro
commented
Sep 20, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4608 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 375 375
Lines 33536 33547 +11
=======================================
+ Hits 33412 33423 +11
Misses 124 124
☔ View full report in Codecov by Sentry. |
mudit2812
approved these changes
Sep 21, 2023
timmysilv
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very cool 😎 🌵
mudit2812
pushed a commit
that referenced
this pull request
Sep 22, 2023
`QuantumScript` and `QuantumTape` now have `_flatten` and `_unflatten` methods and are registered as jax pytrees. [sc-40589]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QuantumScript
andQuantumTape
now have_flatten
and_unflatten
methods and are registered as jax pytrees.[sc-40589]