Add qml.commutator function #5051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5051 +/- ##
==========================================
+ Coverage 99.36% 99.68% +0.31%
==========================================
Files 392 393 +1
Lines 35850 35602 -248
==========================================
- Hits 35623 35489 -134
+ Misses 227 113 -114 ☔ View full report in Codecov by Sentry. |
4 tasks
|
[sc-53926] |
trbromley
reviewed
Jan 15, 2024
albi3ro
reviewed
Jan 15, 2024
mudit2812
reviewed
Jan 15, 2024
mudit2812
reviewed
Jan 15, 2024
mudit2812
reviewed
Jan 15, 2024
mudit2812
reviewed
Jan 15, 2024
albi3ro
reviewed
Jan 22, 2024
albi3ro
reviewed
Jan 22, 2024
albi3ro
reviewed
Jan 22, 2024
albi3ro
reviewed
Jan 22, 2024
albi3ro
reviewed
Jan 22, 2024
albi3ro
reviewed
Jan 22, 2024
albi3ro
reviewed
Jan 22, 2024
albi3ro
reviewed
Jan 22, 2024
albi3ro
reviewed
Jan 22, 2024
Thanks christina! Co-authored-by: Christina Lee <christina@xanadu.ai>
trbromley
reviewed
Jan 23, 2024
6 tasks
albi3ro
reviewed
Jan 24, 2024
albi3ro
reviewed
Jan 24, 2024
Co-authored-by: Christina Lee <christina@xanadu.ai>
Co-authored-by: Christina Lee <christina@xanadu.ai>
albi3ro
approved these changes
Jan 25, 2024
Qottmann
added a commit
that referenced
this pull request
Feb 1, 2024
Adding native commutators for paulis. Works between `PauliSentence` and any of `Operator, PauliWord, PauliSentence` Builds on top of #5051 Todo - [x] Basic functionality - [x] Basic functionality tests - [x] update qml.commutator - [x] changelog --------- Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai> Co-authored-by: Christina Lee <christina@xanadu.ai>
Qottmann
added a commit
that referenced
this pull request
Feb 22, 2024
…r possible (#5098) Upgrade qml.commutator to use pauli artihmetic whenever that is possible (i.e. whenever both operators have a `pauli_rep`. This was initiated in #5051 (comment) Similar things could be done in qml.dot and other points of the codebase. The grander idea is to use fater pauli arithmetic under the hood whenever that is possible. The main feature of this update is performance: ```python op1 = qml.dot(range(30), [X(i) @ X(i+1) for i in range(30)]) op2 = qml.dot(range(30), [Y(i) @ Y(i+1) for i in range(30)]) %timeit qml.commutator(op1, op2) # on main branch 11.9 ms ± 32.2 µs per loop (mean ± std. dev. of 7 runs, 100 loops each) %timeit qml.commutator(op1, op2) # this branch 1.28 ms ± 3.42 µs per loop (mean ± std. dev. of 7 runs, 1,000 loops each) ``` - [x] Basic functionality - [x] Handle Zero case (empty PauliSentence) with 0 * Identity() - [x] Add test ensuring pauli route is taken - [x] All tests pass - [x] Test mixed cases (ops and Paulis) - [x] changelog [sc-56865] --------- Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai> Co-authored-by: Christina Lee <christina@xanadu.ai>
Mandrenkov
added a commit
that referenced
this pull request
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A function to compute commutators between operators, PauliWord and PauliSentence instances.
Work in progress, happy to hear early feedback!