-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for error tracking with TrotterProduct
template
#5384
Conversation
Hello. You may have forgotten to update the changelog!
|
[sc-55441] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5384 +/- ##
==========================================
+ Coverage 99.63% 99.65% +0.01%
==========================================
Files 399 401 +2
Lines 37125 36944 -181
==========================================
- Hits 36990 36815 -175
+ Misses 135 129 -6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I left some nitpick suggestions, but feel free to ignore if sensible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Left a few small comments. I'm confused about the scaling of the error by changes in order and number of steps.
Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com> Co-authored-by: Diego <67476785+DSGuala@users.noreply.github.com>
Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
It doesn't break TortterProduct, Its just not compatible with the error computation. I added a warning to make this clear to users. |
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
Context:
Adding support to compute the error for a given instance of
qml.TrotterProduct
. This is part of the push on error propagation in PennylaneDescription of the Change:
Using the paper "Theory of Trotter Error with Commutator Scaling" to implement upper-bounds on the additive error for the Suzuki Trotter Product formula.
pennylane/resources/error
, moved the baseerror.py
file into this repository (similar changes for the tests)trotter_error.py
file in the error module which contains all of the helper functions along with the implementations for the_one_norm_error
and_commutator_error
functions.ErrorOperation
to change theerror()
from a property to a method. (associated changes in tests)TrotterProduct
to inherit fromErrorOperation
and implemented theerror()
method.Using this error method, we can benchmark the error in approximating time evolution using the Suzuki-Trotter product formulas: