Add PLxPR implementation for qml.transforms.decompose
#6635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
albi3ro
reviewed
Nov 27, 2024
pennylane/transforms/decompose.py
Outdated
| # pylint: disable=import-outside-toplevel | ||
| from pennylane.capture import TransformTracer | ||
|
|
||
| gate_set = tkwargs.pop("gate_set", set(qml.ops.__all__)) |
There was a problem hiding this comment.
What if the same transform is reused?
albi3ro
reviewed
Nov 27, 2024
pennylane/transforms/decompose.py
Outdated
Comment on lines
71
to
81
| gate_set = tkwargs.pop("gate_set", set(qml.ops.__all__)) | ||
|
|
||
| if isinstance(gate_set, (str, type)): | ||
| gate_set = set([gate_set]) | ||
|
|
||
| if isinstance(gate_set, Iterable): | ||
| gate_types = tuple(gate for gate in gate_set if isinstance(gate, type)) | ||
| gate_names = set(gate for gate in gate_set if isinstance(gate, str)) | ||
| gate_set = lambda op: (op.name in gate_names) or isinstance(op, gate_types) | ||
|
|
||
| max_expansion = tkwargs.pop("max_expansion", None) |
There was a problem hiding this comment.
Should we have a way to do this kind of "transform setup" once at capture time?
There was a problem hiding this comment.
That's a good idea. It might be worth adding a setup_transform(targs, tkwargs) function that can be called to do this setup in TransformInterpreter.setup.
pennylane/transforms/decompose.py
Outdated
| @@ -60,7 +61,53 @@ def _operator_decomposition_gen( | |||
| ) | |||
|
|
|||
|
|
|||
| @transform | |||
| def _decompose_plxpr_transform( | |||
| self, primitive, tracers, params, targs, tkwargs, state=None | |||
There was a problem hiding this comment.
Suggested change
| self, primitive, tracers, params, targs, tkwargs, state=None | |
| primitive, tracers, params, targs, tkwargs, state=None |
I was trying to replicate this example and it took me some time to figure out that this was the main issue XD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
test directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
doc/releases/changelog-dev.mdfile, summarizing thechange, and including a link back to the PR.
The PennyLane source code conforms to
PEP8 standards.
We check all of our code against Pylint.
To lint modified files, simply
pip install pylint, and thenrun
pylint pennylane/path/to/file.py.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-72844]