-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make warnings into errors #6641
Open
timmysilv
wants to merge
25
commits into
master
Choose a base branch
from
warnings-as-errors
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6641 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 468 468
Lines 44132 44132
=======================================
Hits 43973 43973
Misses 159 159 ☔ View full report in Codecov by Sentry. |
timmysilv
commented
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Warnings-as-errors is great, and we should enable it.
Description of the Change:
Set all warnings as errors, except for all the warnings that exist today
Benefits:
Any new warnings will immediately be caught and converted into errors
Possible Drawbacks:
To make this extra-useful, someone ought to work on reducing this list by addressing the warnings. At least this makes it more concretely actionable:
ignore
filter line from this filea. fix the now-failing tests by fixing the root cause
b. filter the warnings within the now-failing tests
c. put back the filter and enshrine it forevermore as a PennyLane standard