Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix for an overly aggressive warning #6707

Merged
merged 7 commits into from
Dec 16, 2024
Merged

Conversation

austingmhuang
Copy link
Contributor

Context:
Was raising a warning too aggressively.

Description of the Change:
Small change to make sure using numpy with autograd/jax doesn't raise a warning.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@austingmhuang austingmhuang marked this pull request as ready for review December 11, 2024 17:12
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.62%. Comparing base (056dd9a) to head (041ec0e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6707   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files         476      476           
  Lines       44740    44740           
=======================================
  Hits        44571    44571           
  Misses        169      169           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@soranjh soranjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @austingmhuang, looks good to go.

@austingmhuang austingmhuang enabled auto-merge (squash) December 13, 2024 20:48
@austingmhuang austingmhuang merged commit cffa08a into master Dec 16, 2024
45 checks passed
@austingmhuang austingmhuang deleted the fix_warning_jax_qchem branch December 16, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants