Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameter filtering on qml.data.load_interactive() #6725

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

brownj85
Copy link
Contributor

@brownj85 brownj85 commented Dec 16, 2024

Context:
qml.data.load_interactive() was not actually filtering datasets by the chosen parameters

Description of the Change:

  • Rename _interactive_requests to _interactive_request_parameters
  • _interactive_request_parameters returns the chosen parameters, which are forwarded to qml.data.load()

Benefits:

  • load_interactive() returns only the selected datasets

Possible Drawbacks:

  • None

@brownj85 brownj85 marked this pull request as ready for review December 17, 2024 16:15
Copy link
Contributor

@DSGuala DSGuala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good to me. 🚀 Should we add a test that catches similar bugs in the future?
Happy to merge once CI tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants