SC-85409 | Build and deploy demonstration previews on pull requests #1352

Alan-eMartin · 2025-04-14T21:22:46Z

Goal:

To create timely PR previews when contributing or updating demos.

Summary:

This pull request uses the new v2-build-demos and v2-deploy-demos workflows to:

Build "modified" and new demos.
Save them as artifacts.
Deploy to the SWC database as previews.
Post a comment with preview links.

Other changes:

Improved descriptions of inputs for workflows.

Testing:

I was required to fork the QML repo to push these workflows to master as workflow_run uses the workflow context from master.

Therefore, you can take a look at the following ran actions:
https://github.com/Alan-eMartin/qml/actions

.github/workflows/build-v2-pr.yml

demonstrations_v2/gbs/demo.py

…ll-request' into sc-85409-v-demos-are-built-on-pull-request

doctorperceptron

Nice @Alan-eMartin! 🥳 Left a few questions/comments, but overall looks great.

.github/workflows/v2-build-pr.yml

.github/workflows/v2-deploy-pr.yml

Co-authored-by: Paul Finlay <50180049+doctorperceptron@users.noreply.github.com>

.github/workflows/v2-deploy-demos.yml

rashidnhm

Minor comments but LGTM 🚀

I am guessing teardown of the v1 pipeline will happen in a separate PR? Until then users will get in essence 2 previews built per PR?

.github/workflows/v2-deploy-pr.yml

Alan-eMartin · 2025-04-29T13:06:11Z

Minor comments but LGTM 🚀

I am guessing teardown of the v1 pipeline will happen in a separate PR? Until then users will get in essence 2 previews built per PR?

Thanks for the review @rashidnhm!

No, not exactly. I will keep this in the v2 branch for the time being, and may disable the comment code for now, as frontend work is not completed for this change.

Essentially we will no longer be using gatsby on the frontend, and will be replacing it with NextJS

**Summary:** Allow internal users to build and deploy **all** or a select list of demos. **Related GitHub Issues:** Internal --------- Co-authored-by: Paul Finlay <50180049+doctorperceptron@users.noreply.github.com>

Alan Martin added 2 commits April 14, 2025 17:22

scaffold

b084fc6

Merge branch 'v2' into sc-85409-v-demos-are-built-on-pull-request

fddef21

Alan-eMartin changed the base branch from dev to master April 14, 2025 21:27

github-advanced-security bot found potential problems Apr 14, 2025

View reviewed changes

.github/workflows/build-v2-pr.yml Fixed Show fixed Hide fixed

Alan Martin added 2 commits April 15, 2025 09:07

fmt

2e162d6

test

4b20c96

github-advanced-security bot found potential problems Apr 15, 2025

View reviewed changes

.github/workflows/build-v2-pr.yml Fixed Show fixed Hide fixed

typo

d08388b

github-advanced-security bot found potential problems Apr 15, 2025

View reviewed changes

.github/workflows/build-v2-pr.yml Fixed Show fixed Hide fixed

add fork check

04186c3

github-advanced-security bot found potential problems Apr 15, 2025

View reviewed changes

.github/workflows/build-v2-pr.yml Fixed Show fixed Hide fixed

correct the path, add pseudo steps

26d0389

github-advanced-security bot found potential problems Apr 15, 2025

View reviewed changes

.github/workflows/build-v2-pr.yml Fixed Show fixed Hide fixed

.github/workflows/build-v2-pr.yml Fixed Show fixed Hide fixed

Alan Martin added 2 commits April 15, 2025 10:26

missed checkout?

4895a89

??

778eab6

github-advanced-security bot found potential problems Apr 15, 2025

View reviewed changes

.github/workflows/build-v2-pr.yml Fixed Show fixed Hide fixed

Alan Martin added 7 commits April 15, 2025 10:51

check

799a7c8

test

201d0e7

again

7b28cde

again

6be650b

trigger ci

0395295

trigger

2bb3a6e

trigger, add debug

04b17ee

github-advanced-security bot found potential problems Apr 15, 2025

View reviewed changes

.github/workflows/build-v2-pr.yml Fixed Show fixed Hide fixed

step fails, try moving to job

8776782

github-advanced-security bot found potential problems Apr 15, 2025

View reviewed changes

.github/workflows/build-v2-pr.yml Fixed Show fixed Hide fixed

.github/workflows/build-v2-pr.yml Fixed Show fixed Hide fixed

.github/workflows/build-v2-pr.yml Fixed Show fixed Hide fixed

Alan-eMartin changed the base branch from master to v2 April 15, 2025 17:00

Use env var instead of set-output (depracated)

ec59fde

Alan-eMartin changed the base branch from v2 to master April 15, 2025 17:46

add build step

c259844

Alan-eMartin force-pushed the sc-85409-v-demos-are-built-on-pull-request branch from 106578f to 2c2fa46 Compare April 22, 2025 00:04

Alan Martin added 3 commits April 22, 2025 11:59

add branch and save PR number as artifact

106c6c6

reference the directory not name

c3a79bf

add new workflows

4ac06d4

Alan-eMartin changed the base branch from master to v2 April 23, 2025 18:07

Alan-eMartin changed the base branch from v2 to master April 23, 2025 18:15

remove redundant commemt

17f5665

Alan-eMartin commented Apr 23, 2025

View reviewed changes

demonstrations_v2/gbs/demo.py Outdated Show resolved Hide resolved

Update demonstrations_v2/gbs/demo.py

e9be941

Alan-eMartin changed the base branch from master to v2 April 23, 2025 18:47

Alan-eMartin requested a review from josh146 April 23, 2025 18:50

Alan Martin added 4 commits April 23, 2025 16:52

use variable

b589e46

Merge remote-tracking branch 'origin/sc-85409-v-demos-are-built-on-pu…

013febe

…ll-request' into sc-85409-v-demos-are-built-on-pull-request

remove exit code, use skip?

f69eb3e

FMT, and remove unnecessary ifs

a6e5702

doctorperceptron reviewed Apr 25, 2025

View reviewed changes

Alan-eMartin and others added 2 commits April 28, 2025 08:53

Update .github/workflows/v2-deploy-pr.yml

2f07f37

Co-authored-by: Paul Finlay <50180049+doctorperceptron@users.noreply.github.com>

Update .github/workflows/v2-deploy-pr.yml

373a4b5

Co-authored-by: Paul Finlay <50180049+doctorperceptron@users.noreply.github.com>

Alan-eMartin requested a review from doctorperceptron April 28, 2025 13:07

rm on pr

a402f51

rashidnhm reviewed Apr 28, 2025

View reviewed changes

.github/workflows/v2-deploy-demos.yml Outdated Show resolved Hide resolved

Alan Martin added 2 commits April 28, 2025 16:12

rm branch

deb3ef2

rm usage of branch

f4b3c81

Alan-eMartin requested a review from rashidnhm April 28, 2025 20:15

rashidnhm approved these changes Apr 28, 2025

View reviewed changes

.github/workflows/v2-deploy-pr.yml Outdated Show resolved Hide resolved

.github/workflows/v2-deploy-pr.yml Outdated Show resolved Hide resolved

update how output is created, update gh token

bc9375b

SC-89340 | Add ability to deploy demos manually (#1356)

f712b96

**Summary:** Allow internal users to build and deploy **all** or a select list of demos. **Related GitHub Issues:** Internal --------- Co-authored-by: Paul Finlay <50180049+doctorperceptron@users.noreply.github.com>

Alan-eMartin merged commit a775a1d into v2 Apr 29, 2025
9 checks passed

Alan-eMartin deleted the sc-85409-v-demos-are-built-on-pull-request branch April 29, 2025 15:29

SC-85409 | Build and deploy demonstration previews on pull requests #1352

SC-85409 | Build and deploy demonstration previews on pull requests #1352

Uh oh!

Conversation

Alan-eMartin commented Apr 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Goal:

Summary:

Other changes:

Testing:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

doctorperceptron left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rashidnhm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Alan-eMartin commented Apr 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Alan-eMartin commented Apr 14, 2025 •

edited

Loading