Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OQC Lucy pulse demo #939

Merged
merged 55 commits into from
Oct 27, 2023
Merged

OQC Lucy pulse demo #939

merged 55 commits into from
Oct 27, 2023

Conversation

Qottmann
Copy link
Collaborator

@Qottmann Qottmann commented Sep 26, 2023 •
edited
Loading

Continuing #892

OQC hardware control demo

Content:

  • Intro
  • Single qubit pulse physics
  • Section about qubit/lab frame
  • Calibration
  • X-Y-rotation plane
  • device actually works
  • thumbnail
  • metadata

@Qottmann Qottmann mentioned this pull request Sep 26, 2023
Closed
5 tasks
@github-actions
Copy link

github-actions bot commented Oct 4, 2023 •
edited
Loading

Thank you for opening this pull request.

You can find the built site at this link.

Deployment Info:

  • Pull Request ID: 939
  • Deployment SHA: e7ec925f3678e94c43797940f7ec3c03c2454bc0
    (The Deployment SHA refers to the latest commit hash the docs were built from)

Note: It may take several minutes for updates to this pull request to be reflected on the deployed site.

@Qottmann
Copy link
Collaborator Author

Qottmann commented Oct 4, 2023 •
edited
Loading

Updated the demo to the point where we have data right now. There are two blockers currently prohibiting moving forward with this.

Qottmann
Qottmann commented Oct 23, 2023
View reviewed changes
demonstrations/oqc_pulse.py Outdated
Comment on lines 378 to 390
##############################################################################
# .. figure:: ../demonstrations/oqc_pulse/calibration2.png
# :align: center
# :width: 70%
# :alt: Rabi oscillation for different pulse lengths.
# :target: javascript:void(0);

##############################################################################
#
# As expected, we see a constant :math:`\langle Z \rangle` contribution, as changing :math:`\phi` delays the precession around the Z-axis
# and we land on a fixed latitude. What is changed is the longitude, leading to different rotation axes in the X-Y-plane.
# The qubit-frame interpretation of this picture is that we simply change the rotation axis by setting different phases, as discussed in
# the last paragraph of the transmon physics section above.
Copy link
Collaborator Author

@Qottmann Qottmann Oct 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont understand why this renders like that:
image

@Qottmann
Copy link
Collaborator Author

Qottmann commented Oct 25, 2023 •
edited
Loading

Thanks for the detailed review @alvaro-at-xanadu 🥂
I implemented your suggestions, added code comments and rearranged the intro paragraph.

I am not sure where the rendering issues are coming from. This might be coming from the fact that this is a non-execute demo. I stuck with the commands in the ahs_aquila.py demo to show plots and display outputs 🤔 . So far, without success. edit: thanks @KetpuntoG for fixing the rendering, looks good now!

I would make an exception to not promising future demos since the one we are referring to is pretty much done and dusted 😇

Qottmann
Qottmann commented Oct 26, 2023
View reviewed changes
@Qottmann Qottmann changed the title [WIP] OQC Lucy pulse demo OQC Lucy pulse demo Oct 26, 2023
@trbromley
Copy link
Contributor

I am assuming the URL when published will be https://pennylane.ai/qml/demos/oqc_pulse.html - please let me know if this changes!

@KetpuntoG
Copy link
Contributor

I am assuming the URL when published will be https://pennylane.ai/qml/demos/oqc_pulse.html - please let me know if this changes!

That's correct :)
(not sure if html is necessary)

@Qottmann
Copy link
Collaborator Author

I made some minor polishment adjustments for best UX, where, in particular, I explain a little more in detail the code.
Further, all comments from the two reviews are addressed and implemented.
I am happy with the demo now, looks good to go if @alvaro-at-xanadu agrees and approves 👍

@KetpuntoG
Copy link
Contributor

Nice! Thanks @Qottmann :)
Could you change the name of the thumbnail following the standard naming in other demos? (check this metadata)
Also, I see there is not large_thumbnail_ could you include it in /_static/large_thumbnails? It should be the same as the other thumbnail but with blue background

@Qottmann
Copy link
Collaborator Author

Done ✅ @KetpuntoG

alvaro-at-xanadu
alvaro-at-xanadu approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@alvaro-at-xanadu alvaro-at-xanadu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done and done! Agree, if the new demo is almost ready, then we can promise. However, once that future demo is published, let's also make sure edit this one so that it links to it.

@KetpuntoG KetpuntoG merged commit dbc15be into master Oct 27, 2023
@KetpuntoG KetpuntoG deleted the oqc branch October 27, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KetpuntoG KetpuntoG KetpuntoG left review comments

@alvaro-at-xanadu alvaro-at-xanadu alvaro-at-xanadu approved these changes

@DanielNino27 DanielNino27 DanielNino27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Qottmann @trbromley @KetpuntoG @alvaro-at-xanadu @DanielNino27