Fix: update MS17-010 for Python3 properly; add debug logging #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marshall-Hallenbeck
requested review from
zblurx,
NeffIsBack and
mpgn
as code owners
Marshall-Hallenbeck
changed the title
|
|
mpgn
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears like it thinks the entire file has switched because I moved it to be under the NXCModule class so it can reference
context.logEssentially this properly changes strings to be bytes, and makes it so the header lengths are the same so the request is proper.
Also I added a bunch of debug logging so if errors occur in the future we can easily figure out what's going on.
Closes #101